Check functions #154
Merged
Check functions #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt rather than as else condition). Resolves Issue #151
Run tests on branch
…nto check_functions
Check package
…nto check_functions
cristinamullin
approved these changes
Nov 1, 2022
Collaborator
cristinamullin
left a comment
There was a problem hiding this comment.
Scanned these & they look great. I added a note to the TADA Coding Cheat Sheet for this:
- Utilities.R: Within each new function, add utilities if needed
i. checkColumns: check if required columns to run function are available
ii. checkType: check if type is a dataframe, if logical (boolean)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #151 and #152 by adding two small check functions in Utilities.R and implementing throughout. Error messages manipulated to mirror/pass tests for ConvertDepthUnits function, should be easier to standardize with these new functions rather than having a unique error string for each.