QAPP functions #26
Merged
QAPP functions #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding QAPP functions. QAPPapproved function is working but does not currently include NAs. QAPPDocAvailable is drafted but logic needs review. Added project file retrieval to get sample data file.
Collaborator
Author
|
Let's chat Monday if you have time |
jakegreif
approved these changes
Mar 21, 2022
Contributor
jakegreif
left a comment
There was a problem hiding this comment.
It's looking good! Some small suggestions/observations:
- In both functions you might also want to consider replacing NAs in the QAPPapproved and QAPPDocAvailable columns with "Y" in flag.data for readability.
- It may not matter, but on line 500 you may need to remove the quotes around NA for the command to work properly.
I agree that we should flag/remove N and null in QAPPapproved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding QAPP functions. QAPPapproved function is working but does not currently include NAs. QAPPDocAvailable is drafted but logic needs review. Added project file retrieval to get sample data file.