Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jakegreif
Copy link
Contributor

Completed DepthProfileData function (pending team discussion on particular functionality); updated UpdateUnitRef function to read WQX MeasureUnit domain list from the web

To discuss at the next team meet:

  • Depth measure value fields are of class "character," but to do the conversions they must be numeric. Right now the function is coded so that the data is changed to numeric, but that generates a warning that some values are coerced to numeric (this warning is suppressed in the function). Do we want to keep it this way? If not, we can implement similar logic that we use in the ResultValueSpecialCharacters function.
  • In the sample data I've been using, it looks like they may use the ActivityDepthAltitudeReferencePointText field to record values. It's a text field, but this brings up a potential use case where users rely on one of the depth measure unit fields to know which unit the altitude reference point refers to. This is problematic because when convert = TRUE, the measure units are changed.
    • We should confirm that this use case exists, but even if it does, I think this is too specific of an issue for us to address, particularly at this early stage.

Completed DepthProfileData function (pending team discussion on particular functionality); updated UpdateUnitRef function to read WQX MeasureUnit domain list from the web
@jakegreif jakegreif added this to the Result Flags Page milestone Mar 25, 2022
@jakegreif jakegreif linked an issue Mar 25, 2022 that may be closed by this pull request
@cristinamullin cristinamullin merged commit 777bb35 into develop Mar 25, 2022
@cristinamullin cristinamullin deleted the DepthProfileData branch March 25, 2022 21:11
@cristinamullin
Copy link
Collaborator

Should we keep the DepthProfileData issue open and add your comment above there instead as a reminder to address it later?

@jakegreif jakegreif linked an issue Mar 28, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UpdateMeasureUnitRef DepthProfileData

3 participants