Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MoLi7
Copy link
Collaborator

@MoLi7 MoLi7 commented Aug 19, 2022

This PR addresses issue #236

@MoLi7
Copy link
Collaborator Author

MoLi7 commented Aug 19, 2022

Created this PR to assist inspection to understand the full impact of issue #236 . Will decide whether to merge it with master for a patch release or not. @WesIngwersen

@MoLi7 MoLi7 marked this pull request as ready for review August 19, 2022 20:30
@MoLi7
Copy link
Collaborator Author

MoLi7 commented Aug 19, 2022

Made a few more commits to

  1. ensure order of margin sectors are consistent across tables
  2. ensure all transportation sectors are correctly marked in schema info tables

Now the issue is resolved, and this PR is ready to be merged to master.

Regarding the new release, I propose that we version it v1.1.1 and label it SEF_v1.1.2 because updates in this release mainly affect the supply chain EF calculations. @WesIngwersen

@WesIngwersen
Copy link

Thanks but lets not put SEF in the tag because we dont have a planned SEF release to match

@MoLi7 MoLi7 merged commit 18d5cc1 into master Aug 22, 2022
@bl-young bl-young deleted the issue-236 branch October 26, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants