Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added kafka.ssl.keystore.type and kafka.ssl.trustore.type in surge-co… #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

added kafka.ssl.keystore.type and kafka.ssl.trustore.type in surge-co… #339

merged 1 commit into from
Feb 22, 2023

Conversation

@zachary-rote
Copy link
Collaborator

…mmon

@zachary-rote zachary-rote marked this pull request as draft February 2, 2023 18:52
@github-actions github-actions bot added the enhancement New feature or request label Feb 2, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 59.86% // Head: 59.83% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (55f0a7a) compared to base (d6f9ccb).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   59.86%   59.83%   -0.04%     
==========================================
  Files         152      152              
  Lines        3254     3254              
  Branches      105       92      -13     
==========================================
- Hits         1948     1947       -1     
- Misses       1306     1307       +1
Impacted Files Coverage Δ
...health/windows/actor/HealthSignalWindowActor.scala 93.23% <0.00%> (-1.51%) ⬇️
...a/surge/kafka/KafkaPartitionShardRouterActor.scala 58.38% <0.00%> (-0.68%) ⬇️
.../surge/internal/kafka/KafkaProducerActorImpl.scala 77.32% <0.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachary-rote zachary-rote marked this pull request as ready for review February 19, 2023 19:38
@garyKeorkunian garyKeorkunian merged commit 73ed185 into main Feb 22, 2023
@garyKeorkunian garyKeorkunian deleted the feature/DIM-475552 branch February 22, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n8price n8price n8price approved these changes

@ckmcd ckmcd Awaiting requested review from ckmcd ckmcd is a code owner

+1 more reviewer

@garyKeorkunian garyKeorkunian garyKeorkunian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zachary-rote @codecov-commenter @garyKeorkunian @n8price