Gh/neyunse/test #18
Merged
Gh/neyunse/test #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-multiplatform.yml and build.py
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds multiplatform support to the Visual Novel Engine build system, enabling builds for Windows, Linux, and macOS through GitHub Actions CI/CD.
- Adds GitHub Actions workflow for multiplatform builds and automated releases
- Updates build scripts to handle platform-specific executables and archives
- Removes the
setup.pyfile, indicating a shift away from traditional Python packaging - Increments version from v1.0.0-alpha.12 to v1.0.0-alpha.13
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vne/_version.py | Bumps version to alpha.13 |
| setup.py | Completely removes traditional Python packaging setup |
| main.py | Adds platform detection for bootstrapper executable paths |
| engine.spec | Disables UPX compression and removes extra blank line |
| build.py | Adds platform-specific build outputs and zip naming |
| bootstrapper.spec | Disables UPX compression and adds env.py hook |
| .github/workflows/docs.yml | Adds release trigger for documentation workflow |
| .github/workflows/build-multiplatform.yml | New multiplatform CI/CD workflow with artifact handling |
| exe_source = None | ||
|
|
||
| if platform.system() == "Windows": | ||
| exe_source = os.path.join(os.path.dirname(sys.executable), "lib", "win", "bootstrapper.exe") |
There was a problem hiding this comment.
The Windows-specific exe_source assignment is now unreachable code because it appears after the platform check but outside any conditional block. This line should be moved inside the Windows condition block.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.