ci: update build-multiplatform.yml #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the GitHub Actions workflow to modify the env.py file generation process by creating a temporary file in the root directory before copying it to the target location.
- Changes the env.py generation to create the file in the root directory first
- Adds a copy operation to move the file to the ./vne/ directory
- Uses platform-specific copy commands (copy for Windows, cp for Unix-like systems)
| echo "os.environ['VNE_KEY'] = '${{ secrets.VNE_KEY }}'" >> ./vne/env.py | ||
| echo "import os" >> env.py | ||
| echo "os.environ['VNE_KEY'] = '${{ secrets.VNE_KEY }}'" >> env.py | ||
| copy env.py ./vne/env.py |
There was a problem hiding this comment.
The 'copy' command is not available on Ubuntu runners. This will cause the Ubuntu job to fail since 'copy' is a Windows-specific command.
| echo "os.environ['VNE_KEY'] = '${{ secrets.VNE_KEY }}'" >> ./vne/env.py | ||
| echo "import os" >> env.py | ||
| echo "os.environ['VNE_KEY'] = '${{ secrets.VNE_KEY }}'" >> env.py | ||
| cp env.py ./vne/env.py |
There was a problem hiding this comment.
The 'cp' command is not available on Windows runners. This will cause the Windows job to fail since 'cp' is a Unix-specific command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.