update build-multiplatform.yml, bootstrapper.spec and engine.spec #21
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build configuration and PyInstaller specifications to include pygame dependencies and enable console output for debugging purposes.
- Added pygame and pygame-ce to hidden imports for PyInstaller packaging
- Enabled console output for both engine and bootstrapper executables
- Modified GitHub workflow to trigger only on closed pull requests, removing push triggers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| engine.spec | Added pygame dependencies and enabled console output |
| bootstrapper.spec | Added pygame dependencies and enabled console output |
| .github/workflows/build-multiplatform.yml | Removed push trigger, keeping only closed PR trigger |
| binaries=[], | ||
| datas=[], | ||
| hiddenimports=["pyzipper", "cryptography"], | ||
| hiddenimports=["pyzipper", "cryptography", "pygame", "pygame-ce"], |
There was a problem hiding this comment.
Including both 'pygame' and 'pygame-ce' in hiddenimports may cause conflicts since pygame-ce is a community edition fork of pygame. Consider using only one of these libraries to avoid potential import conflicts.
| hiddenimports=["pyzipper", "cryptography", "pygame", "pygame-ce"], | |
| hiddenimports=["pyzipper", "cryptography", "pygame-ce"], |
| binaries=[], | ||
| datas=[], | ||
| hiddenimports=["pyzipper", "cryptography"], | ||
| hiddenimports=["pyzipper", "cryptography", "pygame", "pygame-ce"], |
There was a problem hiding this comment.
Including both 'pygame' and 'pygame-ce' in hiddenimports may cause conflicts since pygame-ce is a community edition fork of pygame. Consider using only one of these libraries to avoid potential import conflicts.
| hiddenimports=["pyzipper", "cryptography", "pygame", "pygame-ce"], | |
| hiddenimports=["pyzipper", "cryptography", "pygame-ce"], |
No description provided.