Gh/neyunse/dev #26
Merged
Gh/neyunse/dev #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow to compress build artifacts into platform-specific ZIP files before uploading them as artifacts, streamlining the artifact management process.
- Adds ZIP compression for Windows build artifacts
- Updates artifact upload paths to use ZIP files instead of directories
- Removes outdated Spanish comment about code signing
| with: | ||
| name: dist-linux | ||
| path: dist | ||
| path: dist/vne-linux.zip |
There was a problem hiding this comment.
The Linux job references 'dist/vne-linux.zip' but there is no corresponding ZIP creation step for Linux builds like there is for Windows. This will cause the artifact upload to fail as the ZIP file doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.