ci: update build.yml #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow dependencies to change the job execution order. The main purpose is to modify the dependency chain so that the extension build process occurs earlier in the pipeline.
- Changes
build-extensionjob dependency fromcreate-releasetobuild-linux - Updates
create-releasejob to depend onbuild-extensionin addition to existing dependencies
| build-extension: | ||
| runs-on: ubuntu-22.04 | ||
| needs: create-release | ||
| needs: build-linux |
There was a problem hiding this comment.
This change creates a circular dependency. The build-extension job now depends on build-linux, and create-release depends on both build-linux and build-extension. However, the original dependency chain showed build-extension depending on create-release. This circular reference will cause the workflow to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.