Fixes #157 #158
Fixes #157 #158
Conversation
Replaced Injection mixins with WrapOperation mixins. Not really sure why the previous ones broke, they seemed correct.
Removes accidental imports from the MouseHandler mixins for both the Fabric and Norge modules.
EnnuiL
left a comment
There was a problem hiding this comment.
There are only a few small fixes needed;
I do have to say though: I recall not going with @ModifyArgs here because I wanted to modify the locals themselves for better compatibility; I will be merging this though, I'm too exhausted to cook something up myself
| }else{ | ||
| original.call(instance, x, y); |
There was a problem hiding this comment.
| }else{ | |
| original.call(instance, x, y); | |
| } else { | |
| original.call(instance, x, y); |
| }e lse{ | ||
| original.call(instance, x, y); |
There was a problem hiding this comment.
I would be shocked if Java considered this valid (it doesn't)
| }e lse{ | |
| original.call(instance, x, y); | |
| } else { | |
| original.call(instance, x, y); |
(I Really need a new Keyboard)
That's why I used WrapOperation, it's a MixinExtras addition |
Oh no, that's not the issue, the issue is that I was intentionally modifying the local variables in a way where after the modification, all code that uses it would have used it. Anyway, I'll be merging this after testing this |
|
Everything's working out! Thanks for the PR |
Replaced Injection mixins with WrapOperation mixins.
Not really sure why the previous ones broke, they seemed correct.