Shall we use source_column and target_column instead? It is shorter, and it's what is being used as parameter names in the public API, and it is consistent with Pandas.

I also noticed that there is some new code internally using "attribute", so maybe we should converge to use a consistent nomenclature (but this could be a separate commit/PR).

Thanks for the review! I had the same question about whether to use target_column or target_attribute. The main reason I opted for attribute is that in data models like GDC, the concept of columns doesn’t exist, and using column in that context could be somewhat confusing. I would vote to use attribute since it works well both in such cases and in table-to-table scenarios. Additionally, it seems that the term attribute is commonly used in schema matching. I’m also open to using column if that’s preferred.

And yes, my plan was to open a new PR to standardize the selected terminology in parts you mentioned.

What do you think @aecio?

As discussed, we will merge this PR and keep the proposed changes.