feat(ModalPage): extend size prop with any other CSS properties #8949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Добавляем поддержку всех свойств, которые поддерживаются CSS свойством `width`. - Переносим "безопасные" отступы, которые добавляются для desktop версии, с `ModalPage` и `ModalCard` в `ModalOutlet` (для `ModalCard` ).
size-limit report 📦
|
e2e tests |
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8949/f2f786ecf8dc433a5f41b54ce266fa30a83dc26e/pkg/@vkontakte/vkui/_pkg.tgzCommit f2f786e |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8949 +/- ##
==========================================
+ Coverage 96.02% 96.04% +0.02%
==========================================
Files 428 428
Lines 12476 12477 +1
Branches 4114 4115 +1
==========================================
+ Hits 11980 11984 +4
+ Misses 496 493 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EldarMuhamethanov
approved these changes
Sep 9, 2025
BlackySoul
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeпередавать другие значения #8817[ ] e2e-тесты[ ] Дизайн-ревью[ ] Документация фичиОписание
sizeподдержку всех свойств, которые поддерживаются CSS свойствомwidth.ModalPageиModalCardвModalOutlet(дляModalCard).Release notes
Улучшения
sizeтеперь принимает все другие допустимые для CSS свойстваwidthзначения