Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(TabsItem): fix onClick prop without controlled mode #8998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

fix(TabsItem): fix onClick prop without controlled mode #8998

merged 2 commits into from
Sep 25, 2025

Conversation

@EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • Release notes

Описание

После #8484 в TabsItem всегда прокидывается свойство onClick и, поскольку TabsItem использует внутри Tappable, компонент всегда интерактивный, что не очень правильно. Нужно сделать так, чтобы onClick в Tappable прокидывался только, если снаружи прокинут onClick или, если Tabs работает в контролируемом режиме

Release notes

Исправления

  • TabsItem: Исправлена проблема, что TabsItem всегда был интерактивным

@EldarMuhamethanov EldarMuhamethanov added this to the v7.7.1 milestone Sep 25, 2025
@EldarMuhamethanov EldarMuhamethanov self-assigned this Sep 25, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 25, 2025 10:30
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 411.55 KB (+0.01% 🔺)
JS (gzip) 124.81 KB (+0.01% 🔺)
JS (brotli) 102.51 KB (-0.08% 🔽)
JS import Div (tree shaking) 1.55 KB (0%)
CSS 351.56 KB (0%)
CSS (gzip) 43.58 KB (0%)
CSS (brotli) 34.75 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

📊 Найдены изменения в собранных файлах: Отчет

Commit ce33b1a

@codecov
Copy link

codecov bot commented Sep 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (0746db7) to head (ce33b1a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8998   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         449      449           
  Lines       25773    25773           
  Branches     4811     4811           
=======================================
  Hits        24768    24768           
  Misses       1005     1005
Flag Coverage Δ
unittests 96.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8998/96e88b7659662ecc5f13504d7549e03d7ada4908/pkg/@vkontakte/vkui/_pkg.tgz

Commit 96e88b7

inomdzhon
inomdzhon reviewed Sep 25, 2025
View reviewed changes
@EldarMuhamethanov EldarMuhamethanov moved this to 👀 In Review in VKUI Sep 25, 2025
@EldarMuhamethanov EldarMuhamethanov merged commit 01e0d1b into master Sep 25, 2025
30 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/tabs-controlled-mode-fix branch September 25, 2025 13:14
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Sep 25, 2025
vkcom-publisher pushed a commit that referenced this pull request Sep 25, 2025
@EldarMuhamethanov @actions-user
fix(TabsItem): fix onClick prop without controlled mode (#8998)
cc7abad 
* fix(TabsItem): fix onClick prop without controlled mode

* fix(TabsItem): fix condition
@vkcom-publisher
Copy link
Contributor

✅ v7.7.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:tabs-item type:bug

Projects

VKUI
Archived in project

Milestone

v7.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@EldarMuhamethanov @vkcom-publisher @inomdzhon