Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Release notes

Описание

В #9036 был допущен баг. При прокидывании в компонент CustomSelect колбэка onClick и затем при click на нативный select колбэк срабатывает дважды, хотя раньше срабатывал один раз.

Пример:

const onClickFn = vi.fn();

...

<CustomSelect
  ...
  onClick={onClickFn}
  nativeSelectTestId="select"
/>

fireEvent.click(screen.getById('select'));
expect(onClickFn).toHaveBeenCalledTimes(1) // тут будет ошибка, что функция вызвана 2 раза

То же самое происходит с обработчиками onFocus, onBlur.

Release notes

Исправления

  • CustomSelect: Поправлена проблема, что при клике на нативный select обработчик onClick, переданный в компонент, срабатывал дважды. То же самое было с обработчиками onFocus, onBlur

@EldarMuhamethanov EldarMuhamethanov self-assigned this Oct 30, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 30, 2025 10:27
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Oct 30, 2025
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 420.71 KB (+0.02% 🔺)
JS (gzip) 127.87 KB (+0.01% 🔺)
JS (brotli) 104.86 KB (+0.16% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.08 KB (0%)
CSS (gzip) 45.76 KB (0%)
CSS (brotli) 36.26 KB (0%)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit 00809be

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.95%. Comparing base (4b66041) to head (00809be).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9115   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         455      455           
  Lines       26532    26535    +3     
  Branches     4925     4925           
=======================================
+ Hits        25458    25461    +3     
  Misses       1074     1074           
Flag Coverage Δ
unittests 95.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/9115/00809be1dd854cb4d786ee4463e88a2ca26cdc6f/pkg/@vkontakte/vkui/_pkg.tgz

Commit 00809be

@EldarMuhamethanov EldarMuhamethanov merged commit 8d8368e into master Oct 30, 2025
30 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/2432/fix-custom-select-handlers branch October 30, 2025 12:00
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Oct 30, 2025
@inomdzhon inomdzhon added this to the v7.9.2 milestone Oct 30, 2025
@vkcom-publisher
Copy link
Contributor

v7.9.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:custom-select type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants