-
Notifications
You must be signed in to change notification settings - Fork 196
fix(CustomSelect): fix native select handlers call #9115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EldarMuhamethanov
merged 1 commit into
master
from
e.muhamethanov/2432/fix-custom-select-handlers
Oct 30, 2025
Merged
fix(CustomSelect): fix native select handlers call #9115
EldarMuhamethanov
merged 1 commit into
master
from
e.muhamethanov/2432/fix-custom-select-handlers
Oct 30, 2025
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9115 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 455 455
Lines 26532 26535 +3
Branches 4925 4925
=======================================
+ Hits 25458 25461 +3
Misses 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/9115/00809be1dd854cb4d786ee4463e88a2ca26cdc6f/pkg/@vkontakte/vkui/_pkg.tgzCommit 00809be |
inomdzhon
approved these changes
Oct 30, 2025
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 30, 2025
| ✅ v7.9.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:cherry-pick:patch
Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
cmp:custom-select
type:bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В #9036 был допущен баг. При прокидывании в компонент
CustomSelectколбэкаonClickи затем при click на нативныйselectколбэк срабатывает дважды, хотя раньше срабатывал один раз.Пример:
То же самое происходит с обработчиками
onFocus,onBlur.Release notes
Исправления
selectобработчикonClick, переданный в компонент, срабатывал дважды. То же самое было с обработчикамиonFocus,onBlur