fix: enable future_not_send lint #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables the future_not_send lint by removing the lint allowance and fixing all resulting compilation issues. The lint ensures that futures are Send, which is important for async code that may be moved between threads.
Key changes include:
- Removing the
future_not_send = "allow"lint configuration - Converting reference parameters (
&RPCContext<T>) to owned parameters (RPCContext<T>) throughout handler functions - Adding
Send + Syncbounds to trait parameters for serializable types - Adding explicit trait bounds for generic type parameters
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Removes the future_not_send = "allow" lint configuration |
| crates/nfs3_tests/src/server.rs | Adds NfsFileSystem trait bound to Server struct |
| crates/nfs3_server/src/vfs/adapters/iterator.rs | Fixes documentation link formatting |
| crates/nfs3_server/src/rpcwire.rs | Changes context parameter from reference to owned value |
| crates/nfs3_server/src/portmap_handlers.rs | Updates handler functions to take owned RPCContext and adds trait bounds |
| crates/nfs3_server/src/nfs_handlers.rs | Updates NFS handler functions to take owned RPCContext |
| crates/nfs3_server/src/mount_handlers.rs | Updates mount handler functions to take owned RPCContext and adds trait bounds |
| crates/nfs3_server/src/context.rs | Adds NfsFileSystem trait bound to RPCContext struct and implementations |
| crates/nfs3_client/src/rpc.rs | Adds Send + Sync bounds to Pack trait parameters |
| crates/nfs3_client/src/portmapper.rs | Adds Send + Sync bounds to Pack trait parameters |
| crates/nfs3_client/src/nfs.rs | Adds Send + Sync bounds to Pack trait parameters |
| crates/nfs3_client/src/net.rs | Adds Sync bound to Connector trait |
| crates/nfs3_client/src/mount.rs | Adds Send + Sync bounds to Pack trait parameters |
| crates/nfs3_client/src/connect.rs | Adds Send bound to connection type parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.