feat: add createverf parameter to NfsFileSystem::create_exclusive method
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NfsFileSystem::create_exclusive method
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for NFSv3 exclusive create verifiers by extending the createverf3 type and updating the server, filesystem adapters, tests, and examples to pass the verifier through create_exclusive.
- Derive
Defaultforcreateverf3and update tests to use non-zero verifiers - Change the
NfsFileSystem::create_exclusivesignature and implementations to accept acreateverf3argument - Update wasm FS, in-memory FS, mirror FS, and adapters (including examples) to propagate the new verifier parameter
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/nfs3_types/src/nfs3.rs | Added Default derive to createverf3 |
| crates/nfs3_tests/tests/base_tests.rs | Updated tests to pass explicit verifiers |
| crates/nfs3_tests/src/wasm_fs.rs | Added createverf parameter to stub implementation |
| crates/nfs3_server/src/vfs/mod.rs | Updated trait create_exclusive signature & docs |
| crates/nfs3_server/src/vfs/adapter.rs | Added adapter stub for new parameter |
| crates/nfs3_server/src/nfs_handlers.rs | Propagate verifier to handler |
| crates/nfs3_server/src/memfs/mod.rs | In-memory FS stores and compares createverf3 |
| crates/nfs3_server/src/memfs/config.rs | Extracted MemFsConfig into its own module |
| crates/nfs3_server/examples/mirrorfs.rs | Updated mirror FS stub to accept verifier |
| crates/cargo_nfs3_server/src/mirror.rs | Updated CLI mirror to propagate verifier |
Comments suppressed due to low confidence (3)
crates/nfs3_tests/src/wasm_fs.rs:321
- Parameter
createverfis currently unused in this stub; consider renaming to_createverfor prefixing with an underscore to avoid compiler warnings.
createverf: createverf3,
crates/nfs3_server/src/vfs/mod.rs:223
- The
create_exclusivedoc comment does not mention the newcreateverfparameter. Please update the documentation to explain its role in exclusive create semantics.
fn create_exclusive(
crates/nfs3_server/examples/mirrorfs.rs:569
- The
CreateFSObject::Exclusivevariant now requires acreateverf3argument. Update this call to pass the_createverfparameter (e.g.,&CreateFSObject::Exclusive(_createverf)).
.create_fs_object(dirid.as_u64(), filename, &CreateFSObject::Exclusive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nfs3_types:
Defaultfor createverf3nfs3_server:
NfsFileSystem::create_exclusivemethodNfsFileSystem::create_exclusivefor MemFs