Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: example with Svelte 5 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 18, 2025
Merged

feat: example with Svelte 5 #51

merged 20 commits into from
Mar 18, 2025

Conversation

@musaabg
Copy link
Contributor

@musaabg musaabg commented Mar 13, 2025

PR includes a working example with the latest version of Svelte 5 (currently > 5.23).
Thanks for all your work on this crate!

@Valerioageno
Copy link
Owner

Hey @musaabg, thanks for it!
I'd not add examples for every framework version. Could we just update the existing vite-svelte? Actually with a separate PR I'll remove the example with React17
Also we should update the tests/assets/ to use your simplified bundle instead of the svelte-4. Just to be sure that future builds will not impact svelte output

musaabg added 13 commits March 16, 2025 17:15
@musaabg
chore: include .gitignore file
961dd41
@musaabg
feat: update ssr_rs to current
8b6a9f9
@musaabg
feat: update vite, vite-plugin-svelte, and svelte to current (svelte 5)
94ad734
@musaabg
fix: update script typos for client & ssr builds
3f7b90d
@musaabg
chore: updated pkg name for clarity; equivalent "preview" command for…
01a07ec 
… rust+vite build; pnpm-lock file
@musaabg
feat: client entry updated for svelte 5
a777b91
@musaabg
feat: server entry updated for svelte 5
e84fb27
@musaabg
feat: add svelte:head component to example to better show new bundle …
840cb79 
…output
@musaabg
chore: rm unused fn (?)
fbcbc32
@musaabg
feat: update backend to expect new bundle from svelte 5
8096918
@musaabg
test: iife output and test for expected bundle from svelte 5
f4cc8e9
@musaabg
chore: update svelte 4 test fn name for clarity
d9edadb
@musaabg
chore: rm after updates to original vite-svelte example
7d859ce
@musaabg
Copy link
Contributor Author

musaabg commented Mar 16, 2025

Sure thing! I've folded my updates to vite-svelte so now the example uses the latest versions of Svelte, Vite, and this crate. I've also updated tests/assets/ with a new bundle from Svelte 5, along with a new test to tests/svelte.rs. Let me know if you'd like any changes.

Valerioageno
Valerioageno approved these changes Mar 18, 2025
View reviewed changes
Copy link
Owner

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this addition

@Valerioageno Valerioageno merged commit 8a5fc80 into Valerioageno:main Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valerioageno Valerioageno Valerioageno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@musaabg @Valerioageno