fix(brush.ts): 避免第二次框选，前面的选择框未消失 #1750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
在drawEnd之后，更新brushComponent，以避免第一次选区的外框继续保留 fix VisActor#1720
skie1997
reviewed
Dec 13, 2023
| this._needEnablePickable = true; | ||
| } | ||
| if (operateType === IOperateType.drawEnd) { | ||
| this._updateBrushComponent(region, componentIndex); |
There was a problem hiding this comment.
brush支持绘制多个选框，即brushMode设置为multiple，此时drawEnd之后不应该清除之前的选框（如下图），所以在这里修改逻辑可能并不合适。
当前case的问题在于:
drawEnd之后进行了spec更新，导致之前的brush选框没有被正确清除
解决方法:
updateSpec后会走brush.release()卸载先前的brush, 所以更好的方法是在这里release()清空brush选框
MR: #1755
解决后效果：
|
@key7men 感谢你的提交，相关问题已经使用其他方案修复 |
OKAY，感谢修改。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在drawEnd之后，更新brushComponent，以避免第一次选区的外框继续保留
fix #1720
🤔 This is a ...
🔗 Related issue link
#1720
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough