Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@joyehuang
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

Resolves issue #225

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add unit test for waterfall graph
🇨🇳 Chinese 为瀑布图增加单元测试

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

- Add comprehensive test cases for waterfall chart generation
- Test covers basic waterfall spec generation, field mapping, total configuration
- Test covers axes configuration and stack label settings
- Test covers edge cases like empty dataTable and missing cell fields
- Resolves issue VisActor#225
@github-actions github-actions bot added the vmind label Jul 7, 2025
Copy link
Contributor

@666haiwen 666haiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@666haiwen 666haiwen merged commit 7ba4a96 into VisActor:develop Jul 10, 2025
2 checks passed
@joyehuang joyehuang deleted the feat/add-waterfull-unit-test branch July 10, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants