Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(Client): Allow sending data in DELETE requests #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2022
Merged

feat(Client): Allow sending data in DELETE requests #22

merged 1 commit into from
Apr 13, 2022

Conversation

@joseotoro
Copy link
Member

No description provided.

mgmacias95
mgmacias95 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@mgmacias95 mgmacias95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseotoro joseotoro merged commit fce0077 into master Apr 13, 2022
@joseotoro joseotoro deleted the client-delete-data branch April 13, 2022 14:17
@plusvic
Copy link
Member

plusvic commented Apr 13, 2022

This breaks backward compatibility. Is it strictly necessary? Do we have some API that expects to receive a DELETE request with data in the body?

@joseotoro
Copy link
Member Author

In order to delete items from collections we need it: https://developers.virustotal.com/reference/collectionsidrelationship-2

@joseotoro
Copy link
Member Author

We can change it and just implement DeleteData separately so it doesn't break the Delete.

joseotoro added a commit that referenced this pull request Apr 13, 2022
@joseotoro
Revert "feat(Client): Allow sending data in DELETE requests (#22)"
801a566 
This reverts commit fce0077.
@joseotoro
Copy link
Member Author

#23

joseotoro added a commit that referenced this pull request Apr 13, 2022
@joseotoro
Do not break compatibility with Client's Delete (#23)
e010bf4 
* Revert "feat(Client): Allow sending data in DELETE requests (#22)"

This reverts commit fce0077.

* Do not break compatibility with Client's Delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgmacias95 mgmacias95 mgmacias95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joseotoro @plusvic @mgmacias95