modules/SceCommonDialog: Fix 'check_save_file' crash on Linux #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is on what game ? |
EXtremeExploit
previously approved these changes
Sep 21, 2025
Known:
|
i see yes, sly cooper for empty save get len 0 but not null hmm ah click on no crashing ok lol |
1a1957d to
31171c7
Compare
|
i have founded one bug and issue for sly cooper, i open pr for fix it later |
- When `iconPath` is empty string, `vfs::read_file` will try to open dictory `ux0` as a binary file to read, which have no effect on Windows but crash on *nix (Linux/Android/...). - `std::ifstream` can open a directory as file on *nix (but can not on Windows), and after that `std::ifstream::tellg()` return the max value that the return type can represent (strangely not fail), which leads to throwing an exception when buffer is being resized.
31171c7 to
cf8fa31
Compare
EXtremeExploit
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iconPathis empty string,vfs::read_filewill try to open dictoryux0as a binary file to read, which have no effect on Windows but crash on *nix (Linux/Android/...).std::ifstreamcan open a directory as file on *nix (but can not on Windows), and after thatstd::ifstream::tellg()return the max value that the return type can represent (strangely not fail), which leads to throwing an exception when buffer is being resized.