Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stevezhengshiqi
Copy link
Contributor

This commit could prevent potential memory leaks when FMCN/SSCN not found in ACPI table.
Big thanks to @williambj1

Copy link
Collaborator

@kprinssu kprinssu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @ben9923 Please take look as well.

Copy link
Member

@ben9923 ben9923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If evaluateObject doesn't return success, value would probably be nullptr anyway, making the only case it helps is when method exists but does not return an array.
Did you really encounter a memory leak here?

While highly unlikely object is non-null and invalid, let's get this in, in case of some wacky user-defined method :)

@kprinssu
Copy link
Collaborator

If evaluateObject doesn't return success, value would probably be nullptr anyway, making the only case it helps is when method exists but does not return an array. Did you really encounter a memory leak here?

While highly unlikely object is non-null and invalid, let's get this in, in case of some wacky user-defined method :)

It's mainly the reference count on object. I am going to merge this in.

@kprinssu kprinssu merged commit 4d9670f into VoodooI2C:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants