Add device selector #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us load the package for unsupported devices without crashing. There are probably more incompatibilities, but the windows DACs were the ones causing a problem for me.
There's some other problems with this example but those changes will come later.
5a82d8f to
b7d16c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having each example specify which device it wants to use, we can call getDevices(). This always adds a Simulator device, but if process.env.DEVICE is truthy, it will search for a real DAC. If process.env.DEVICE is the name of a DAC, it will use that without searching.
This pull also adds a method to Device so we can ask if the device is supported on the current system. Right now, this is only used to check the OS on windows-only DACs.
Note that I based this branch off add-shutdown-handler, so the changes from #70 are also included here.