prod/ODWithWLS #297
prod/ODWithWLS #297
Conversation
Based on Super-K cosmic flux extrapolated to Hyper-K site
Embryo classes and methods for combined PMTs collection stacking action
Working. Need to add that in stacking action now
Add a new method to apply QE inside StackingAction for different PMT collection
The stacking action takes into account the QE of the PMTs and the absorption of the WLS plates
…ngAction class. Will be created once and used in SteppingAction to increase speed of simulation.
Create the emission spectrum for the WLS plates outside of the Steppi…
And more tests
|
I'm happy the validation is correctly working on your branch now, but the output is still different to what's expected unfortunately... will delve next week |
tdealtry
left a comment
There was a problem hiding this comment.
Thanks for all this @mahditaani
I've had a skim through it all again, and just a few comments left (most trivial, couple are a bit more work)
Almost time to get this PR merged in!
src/WCSimRunAction.cc
Outdated
| wcsimrandomparameters->SaveOptionsToOutput(wcsimrootoptions); | ||
|
|
||
| //set Tree for gathering photon info inside stepping action | ||
| photonTree = new TTree("photons","Photon Tree"); |
There was a problem hiding this comment.
Ok so I just run 10 events with OD.mac, and this is huge!
- Photon tree: 38 MB
- wcsimT tree: 1 MB
So we defintiely need to switch this off by default. I'd suggest something like
- add a
booloption toWCSimRunActionMessengercalledSaveWLSPhotonInfo - only create the
TTreehere if that'strue - only
Fill()the tree inWCSimSteppingAction.ccif the tree is notnull
It'd also be good to improve the description e.g.
| photonTree = new TTree("photons","Photon Tree"); | |
| photonTree = new TTree("photons","Photons in WLS Tree"); |
| // COMBINED PMTS CLASS | ||
| // Goal is to instantiate purely virtual WCSimPMTObject Classes to contained an extended | ||
| // QE information of several PMTs collection | ||
| // Useful for applying QE in stacking action when several PMTs collection are defined |
There was a problem hiding this comment.
Ok thanks for this. Removing the WCSimBasicPMTObject class sounds great
|
Thanks for all this work @mahditaani and the rest of the OD group! |
This is the latest version of the hyper-k od. This includes the most recent hyper-k geometry as well as fixes to the photocoverage code.