Updated Radon model #292
Updated Radon model #292
Conversation
…ms file to not have timestamp in its name, minor modification of the model
|
I did some small modifications in the code:
|
|
Hi, is there any news about merging this PR? |
tdealtry
left a comment
There was a problem hiding this comment.
Thanks for this @gpronost
I particularly like how you've removed a lot of constants, and replaced them with a handful of arrays
There's some specific comments inline, but a more general one is that (as a complete beginner to this) I've no idea what a lot of the variables in WCSimGenerator_Radioactivity are. So could you please document each (doxygen preferred, but not essential) in WCSimGenerator_Radioactivity.hh
Then I'll take a closer look at WCSimGenerator_Radioactivity.cc
Note that I'm going to open/close this PR to force a Travis build
|
Hi Tom, thank you for your comments. I will try to answer them as soon as I have some time (it's been a while since I wrote this code). |
|
I added more documentations (Not in doxygen however, I'm sorry for this). |
|
Last commit (d0baffd) should not have any effect, as these modifications are already on develop. I don't understand why github find difference however. If it's an issue, I will revert it. |
tdealtry
left a comment
There was a problem hiding this comment.
Thanks for the documentation. It really helped.
I've put a few more comments inline. Additionally
- You're using
std::coutandstd::endlinstead ofG4cout,G4errandG4endl. Can you switch to the G4 versions please? (I seem to remember a few years ago something I was doing not using the G4 versions caused some mangled printout (e.g. lines getting mixed up)) - Can you revert the last commit (about cmake & stuff)? It is easier (if you want it in for any testing, pulling from develop should work ok, since there are no conflicts) I agree that github handles this situation badly (it maybe shows the diff between your branch and the last time you pulled from the develop branch?)
| fConcentrationID = 0; | ||
| fConcentrationFV = 0; |
There was a problem hiding this comment.
I'm probably missing something obvious, but where are these set for scenario 0? From what I can see, "uniform" means "uniformly no radon"
There was a problem hiding this comment.
They are not set for scenario 0. However "uniform" doesn't means "uniformly no radon", it only means we generate radon decay randomly in the detector without following a model (with an "uniform" distribution)
| double vZ [2] = { lZ , lR2 }; | ||
| double vR2[2] = { lR2, lZ }; | ||
| //----------------------------------// | ||
| fRnLambda_Global = par[0]; |
There was a problem hiding this comment.
Again, I might be missing something, but where is par[1] used?
From the header file (and top of this file)
par[1] is the M / bin
There was a problem hiding this comment.
Ah, indeed, it's an artifact of the old version, I removed it I think, I will change the comments.
Co-authored-by: Tom Dealtry <[email protected]>
Co-authored-by: Tom Dealtry <[email protected]>
Co-authored-by: Tom Dealtry <[email protected]>
…ny effect on trunk)" This reverts commit d0baffd.
|
I included your comments |
tdealtry
left a comment
There was a problem hiding this comment.
Wonderful. Many thanks for this @gpronost
I've just pushed a trivial change (removing the comment about par[1] in the .cc file - I couldn't do it as a suggestion on github so thought easiest thing to do it there)
Will wait for the travis to go green, then I'll merge
New version of the Radon model (will be presented at the software/physics pre-meeting this evening)