Rearrange optional compilation flag#374
Merged
tdealtry merged 11 commits intoWCSim:developfrom Oct 4, 2023
Merged
Conversation
guiguem
reviewed
Sep 13, 2023
Contributor
|
I just added the WCSimCore library into the list of produced libraries. This should ease the importation and linkage of these two libraries into subsequent libraries via CMake |
Contributor
|
Thanks for the new commits @gondiaz. From your side, are there any extra things you want to put into this PR? From my side, there's 3 outstanding things I'd like before I can merge this (don't worry, 2 are trivial)
|
Co-authored-by: Tom Dealtry <[email protected]>
Contributor
Author
|
Done, as for the |
tdealtry
approved these changes
Oct 4, 2023
Contributor
|
The auto checks are happy, and I verfied that the cosmics are happy, so I'm happy. Thanks for this @gondiaz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To install WCSim dependent packages the
WCSIM_CHECK_GEOMETRY_OVERLAPSneed to be accesible.This is done by setting the variable in the
WCSimConfig.cmakevia itsWCSimConfig.cmake.intemplate when WCSim is installed.To do that, we need to move the definition of
WCSim_Geometry_Overlaps_CHECKto the higher hierarchy CMakeLists file from the its previous definition at thesrcsubdirectory.