Add shape options for point_data layers; COUNTRY=cambodia #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good now, thanks @ericboucher. I tried displaying two point layers simultaneously (the main reason we needed this) and it works as well. |
wadhwamatic
approved these changes
Nov 4, 2025
|
Visit the preview URL for this PR (updated for commit cee7539): https://staging-prism-frontend--1590-snnf37lm.web.app (expires Sun, 07 Dec 2025 09:57:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4de97634797dc19a4f4938b370446c2b3ddc1c37 |
gislawill
reviewed
Nov 7, 2025
| type="symbol" | ||
| layout={{ | ||
| 'icon-image': iconShape, | ||
| 'icon-size': 1.5, |
Collaborator
There was a problem hiding this comment.
Not needed now but I could easily see this being useful to configure in layers.json in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1358 by adding an optional point data layer parameter
icon_shape : 'point' (default)| 'square' | 'triangle' | 'diamondHow to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: