chore(InputText): migrate InputText component to belonging #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theo-mesnil
reviewed
Oct 16, 2025
| inputProps.disabled && 'disabled' | ||
| )} | ||
| > | ||
| {React.cloneElement(icon, { ...icon.props, size: iconSize })} |
There was a problem hiding this comment.
Maybe this can work ?
Suggested change
| {React.cloneElement(icon, { ...icon.props, size: iconSize })} | |
| <Icon size={iconSize} /> |
There was a problem hiding this comment.
I thought it was working and then my tests broke
It's due to the weird implem of the PasswordInput:
<InputText
{...rest}
icon={
<ToggleButton
aria-label={toggleAriaLabel ?? (isHidden ? 'Show password' : 'Hide password')}
data-testid={dataTestId}
isHidden={isHidden}
onClick={handleToggle}
/>
}
iconPlacement="right"
ref={ref}
type={type}
/>
See, the icon is a component 🤯
I will handle that in my next component PR, as I have the PasswordInput assigned to me
202a93c to
4f08526
Compare
theo-mesnil
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
HOW TO TEST
Go to https://wui-208-input-text.preview.welcome-ui.com/components/input-text
or start your project locally
SCREENSHOTS / SCREEN RECORDINGS
COMPATIBILITY
QA