Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: migrate Badge component for belonging #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: chore: belonging rebranding [WUI-226]
merged 4 commits into from
Oct 21, 2025
Merged

feat: migrate Badge component for belonging #2986

merged 4 commits into from
Oct 21, 2025

Conversation

@stevenpersia
Copy link
Contributor

@stevenpersia stevenpersia commented Oct 16, 2025 •
edited
Loading

DESCRIPTION

⚠️ New badge here! I took the initiative to:

  • replace the variant name primary with brand
  • set the variant to warm as the default
  • set the size to md as the default

If this is a problem, I can modify it!

HOW TO TEST

Take a look here: https://wui-236-component-badge.preview.welcome-ui.com/components/badge

COMPATIBILITY

  • Tested on Safari (desktop)
  • Tested on Chrome (desktop)
  • Tested on Firefox (desktop)
  • Tested on mobile device sizes
  • Tested on tablet device sizes
  • Tested on IOS Safari (either device or simulator)

QA

  • Thoroughly tested in local environment
  • Added tests for all new features
  • Added tests that considered edge cases

@stevenpersia stevenpersia requested a review from a team as a code owner October 16, 2025 15:31
@linear
Copy link

linear bot commented Oct 16, 2025

WUI-236 COMPONENT | BADGE

@github-actions
Copy link

👀 Visit Preview

theo-mesnil
theo-mesnil reviewed Oct 16, 2025
View reviewed changes
@theo-mesnil
Copy link
Contributor

Please rebase to had correct Text component

@stevenpersia stevenpersia force-pushed the wui-236-component-badge branch from 45d725b to d1671f4 Compare October 20, 2025 09:03
@stevenpersia stevenpersia changed the title feat: add migration script for Badge component feat: migrate Badge component for belonging Oct 20, 2025
@stevenpersia stevenpersia merged commit 4adab2f into chore-belonging Oct 21, 2025
11 checks passed
@stevenpersia stevenpersia deleted the wui-236-component-badge branch October 21, 2025 08:57
cnairi pushed a commit that referenced this pull request Oct 21, 2025
@stevenpersia @cnairi
feat: migrate Badge component for belonging (#2986)
7f3410b 
* feat: update Badge component

* feat: add migration script for Badge component

* fix: correct variant usage in Badge example

* feat: integrate Text component in Badge
cnairi pushed a commit that referenced this pull request Oct 22, 2025
@stevenpersia @cnairi
feat: migrate Badge component for belonging (#2986)
ab4650f 
* feat: update Badge component

* feat: add migration script for Badge component

* fix: correct variant usage in Badge example

* feat: integrate Text component in Badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnairi cnairi cnairi left review comments

@theo-mesnil theo-mesnil theo-mesnil approved these changes

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenpersia @theo-mesnil @cnairi