Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New OpenPMD laser input (rereloaded) #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxThevenet merged 29 commits into from
Nov 25, 2025
Merged

New OpenPMD laser input (rereloaded) #189

MaxThevenet merged 29 commits into from
Nov 25, 2025

Conversation

@delaossa
Copy link
Collaborator

@delaossa delaossa commented Nov 17, 2025

This PR makes a few convenient changes for the initialization of laser pulses from a OpenPMD file with OpenPMDPulse.
Since this class depends on FromOpenPMDProfile in LASY, this PR is also intended to make Wake-T compatible with the new H5 reader in LASY-org/lasy#384

  • Laser initialization from file, follows FBPIC standard.
  • Implement new H5 reading format.
  • Add polarization attribute to laser envelope diagnostics.

delaossa and others added 19 commits March 27, 2025 11:03
@delaossa
Properly initializes the position laser pulse when reading from openP…
a34e905 
…MD file.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4673236 
for more information, see https://pre-commit.ci
@delaossa
Add envelopeField as attribute.
f0acaa3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4737469 
for more information, see https://pre-commit.ci
@delaossa
Changes for the use of the new FromOpenPMDProfile in Lasy.
bffa6d1
@delaossa
Update arguments names in OpenPMDPulse.
f93461e
@delaossa
Add polarization attribute to envelope field.
ef6ecab
@delaossa
Fix polarization format (it always (1,0)).
6aff9f6
@delaossa
Allows read/write with circular polarization.
e56aae6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2df5a4d 
for more information, see https://pre-commit.ci
@delaossa
Setting pol with complex numbers does not work. Go back to always (…
b7020cb 
…1, 0).
@delaossa
Fix polarization issue: attribute polarization had to be a `np.arra…
6f19285 
…y` instead of tuple.
@delaossa
Add iteration to OpenPMDPulse. Relax polarization detection.
81bf87f
@delaossa
Change a word to trigger tests
1dac2a9
@delaossa
Lower assert precision to pass test
d5fa72b
@delaossa
Replace assert with assert_almost_equal to pass test
bdea953
@delaossa
Merge branch 'dev' of github.com:Wake-T/Wake-T into dev
5a9f0e7
@delaossa
Merge branch 'dev' into read_openpmd
179fa30
@delaossa
Merge branch 'dev' of github.com:Wake-T/Wake-T into read_openpmd
f58b7c2
@delaossa
Copy link
Collaborator Author

delaossa commented Nov 17, 2025 •
edited
Loading

@AlexanderSinn As you hinted here #181 (comment) , the codacy test works when the PR comes from the main repo, but not from forks

@delaossa
Copy link
Collaborator Author

delaossa commented Nov 18, 2025

Add unit test for OpenPMDPulse

@delaossa delaossa requested review from MaxThevenet and removed request for AlexanderSinn November 18, 2025 09:53
@codacy-production
Copy link

codacy-production bot commented Nov 18, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e94d9241 ✅ 86.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e94d924) Report Missing Report Missing Report Missing
Head commit (f256c05) 4740 2539 53.57%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#189) 15 13 86.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

MaxThevenet
MaxThevenet reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! See 1 comment below.

@MaxThevenet MaxThevenet merged commit 7b0fb09 into dev Nov 25, 2025
8 checks passed
@MaxThevenet MaxThevenet deleted the read_openpmd branch November 25, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delaossa @MaxThevenet