Activate runtime type checks #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ecd435 to
b55bf44
Compare
Collaborator
|
@ShinWonho and I made some changes for the temporary fix:
|
…nvoke-typechecks
ShinWonho
approved these changes
Jul 23, 2024
Collaborator
Author
|
Thanks @presenthee & @ShinWonho! |
rossberg
pushed a commit
that referenced
this pull request
Jan 20, 2025
Alan-Liang
pushed a commit
to altk-contrib/spectec
that referenced
this pull request
Aug 8, 2025
This patch brings the encoding and decoding of tag imports in sync with the exception handling proposal. Resolves Wasm-DSL#101.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds previously missing runtime type checks on the arguments to the instantiate and invoke meta functions. The interpreter cannot currently handle these and will probably need some manual exemptions.
@ShinWonho, can you please look into this? To at least get the spec document correct quickly, perhaps the simplest temporary fix is to somehow just ignore these premises in the interpreter backend.