Do not bundle wdisplays by default for packaging reasons #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The problem is with things like this where wdisplays isn't getting attention from its current upstream maintainer. The other thing as mentioned on chat, is that it makes it easier for packagers that want to package wcm and wdisplays separately. I will approve this, and consider removing wdisplays as a subproject altogether. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now the meson options default is flipped
it was suggested to remove the submodule but it feels like removing awareness of wdisplays.
should have minimal impact on users since it already detects and shows wdisplays if its in PATH
this should be labelled as a optional dependency somewhere in documentation but im not too familiar