-
Notifications
You must be signed in to change notification settings - Fork 10
add internationalisation #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks fine to me but code style needs fixing and I'd like to see at least one plugin with a po file, for testing before we merge this. |
|
All the plugins will get po, don't worry :D, but that's why it's a draft |
soreau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pleased to see these pull requests shading up to build infrastructure for translations in wcm. I just have one minor nitpick with the build system code. I will let you address what @NamorNiradnug has pointed out, as I can't really comment on these parts of the code. But perchance, @NamorNiradnug can offer a native language translation too.
|
I am linking this pixdecor pull request here, since it is serving as part of the test bed for the translation functionalities. |
I'll try! |
|
@NamorNiradnug I have marked all conversations as resolved, but you are also free to send further PRs to be discussed. Thanks for your review! @Secret-chest Thanks! |
|
Thank you @soreau and @NamorNiradnug |
|
@NamorNiradnug If you want to do a translation for wcm, there is a guide in the wiki now. The TL;DR is that you have to generate a .po file from the plugin xml or wcm.pot and fill in the msgstr entries with the string translations, then add and commit the .po file and parent directories. Let me know if the guide is clear enough to understand or if you have any questions. It might be easiest to start with wcm and pixdecor plugin, and maybe do the wayfire and wayfire-plugins-extra plugins if you have time. |
This PR allows
mofiles for translations to plugins' XML file in a structure such as:Additionally, it makes the WCM's own UI use gettext so that it can be localised. I have also written PO files for Romanian.
ITS spec to generate the
pot(using itstool) from a plugin XMLNo changes to plugins or to their XML are required, but to be localised they will need to ship their own PO files as in the example above.
Checklists
Plugin support checklist
Other tasks