Thanks to visit codestin.com
Credit goes to github.com

Skip to content

“Infinite” CSS animation durations render page unresponsive #49660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Aug 20, 2025
Merged

“Infinite” CSS animation durations render page unresponsive #49660

webkit-commit-queue merged 1 commit into from
Aug 20, 2025
+52 −1

Conversation

@graouts
Copy link
Contributor

@graouts graouts commented Aug 20, 2025 •
edited by webkit-early-warning-system
Loading

179a908

“Infinite” CSS animation durations render page unresponsive
https://bugs.webkit.org/show_bug.cgi?id=297596
rdar://158775366

Reviewed by Simon Fraser.

If the duration of an animation is extremely large, don't attempt to resolve the timing function.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-duration-infinite-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-duration-infinite-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-duration-infinite.html: Added.
* Source/WebCore/platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::transformProgress const):

Canonical link: https://commits.webkit.org/298975@main

50e2cb8

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@graouts graouts self-assigned this Aug 20, 2025
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label Aug 20, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 20, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 5c87078)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
  🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@graouts graouts force-pushed the eng/Infinite-CSS-animation-durations-render-page-unresponsive branch from 5c87078 to 71f6a6f Compare August 20, 2025 16:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 20, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 71f6a6f)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@graouts graouts force-pushed the eng/Infinite-CSS-animation-durations-render-page-unresponsive branch from 71f6a6f to 56ebda1 Compare August 20, 2025 16:53
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 20, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 56ebda1)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@graouts graouts force-pushed the eng/Infinite-CSS-animation-durations-render-page-unresponsive branch from 56ebda1 to 50e2cb8 Compare August 20, 2025 16:54
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 20, 2025 •
edited
Loading

EWS run on current version of this PR (hash 50e2cb8)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 20, 2025
@graouts
“Infinite” CSS animation durations render page unresponsive
179a908 
https://bugs.webkit.org/show_bug.cgi?id=297596
rdar://158775366

Reviewed by Simon Fraser.

If the duration of an animation is extremely large, don't attempt to resolve the timing function.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-duration-infinite-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-duration-infinite-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-duration-infinite.html: Added.
* Source/WebCore/platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::transformProgress const):

Canonical link: https://commits.webkit.org/298975@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Infinite-CSS-animation-durations-render-page-unresponsive branch from 50e2cb8 to 179a908 Compare August 20, 2025 20:43
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Aug 20, 2025

Committed 298975@main (179a908): https://commits.webkit.org/298975@main

Reviewed commits have been landed. Closing PR #49660 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 179a908 into WebKit:main Aug 20, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 20, 2025
@graouts graouts deleted the eng/Infinite-CSS-animation-durations-render-page-unresponsive branch August 20, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smfr smfr smfr approved these changes

@nt1m nt1m Awaiting requested review from nt1m

@anttijk anttijk Awaiting requested review from anttijk

@rreno rreno Awaiting requested review from rreno

@heycam heycam Awaiting requested review from heycam

@annevk annevk Awaiting requested review from annevk

Assignees

@graouts graouts

Labels

Animations Bugs related to CSS + SVG animations and transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graouts @webkit-early-warning-system @webkit-commit-queue @smfr