Store the path to the user’s avatar #6443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This denormalization step allows us to show the user’s avatar without joining other tables or fetching additional data on runtime.
BurntimeX
approved these changes
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will store the relative pathname for a user’s avatar in the user table. This permits us to display the avatar without having to rely on joining any other table, using the user storage or fetching additional data on runtime.
The implementation in
StaticAvataris a bit sketchy because it pretends that the avatar is 128x128 even if it could be larger than that. From what I can tell those methods aren’t used in any meaningful way and it avoids storing extra values or doing expensive file I/O to determine it on runtime. We can possibly just deprecate thegetWidth()andgetHeight()method but this is out of scope for this PR.