Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aperez-worklytics
Copy link
Contributor

@aperez-worklytics aperez-worklytics commented Oct 2, 2025

  • Not required to paste ACCESS_TOKEN during installation.
  • For jira:
    • dropped read:accounts from permissions, as it is not used
    • added links with the permission requested vs the endpoint it is used

Update docs for Confluence, Jira. Update tooling.

Features

confusing docs in jira scopes
in Jira/confluence case, does customer actually NEED to fill access_tokn

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes?
    • NOTE in CHANGELOG.md anything that will show up in terraform plan/apply that isn't
      obviously a no-op? yes, for documenting purposes only
    • breaking changes? if in module/example that is NOT marked alpha, requires major version
      change no

eschultink and others added 22 commits September 15, 2025 10:28
* Updated rules

* Updated rule for isMove

* Updated test result
* add some clarity to header handling

* improve naming of it on endpoint

* fix rename
* expose configurable google workspace key rotation; implement it in a better way

* Update infra/examples-dev/gcp/google-workspace-variables.tf

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
* document some additional bulk file settings

* some fixes for jira/confluence docs

* fix passing through columnsToPseudonymizeIfPresent; add tests to cover that; generalize module testing infra

* test the gcp-host module

* doc zoom Server-to-Server OAuth app creation perm in roles

* line-wrapping in zoom docs

* doc requirement for Cloudscheduler admin; and note that it's only least-privileged extant role; a less-privileged custom role is possible

* fix test file per bugbot suggestion

* document 'applyOnlyWhen'

* try to fix test for tf 1.6.x

* add CI coverage of more recent tf versions

* typo in salesfroce docs

* recover gcp-host CI mock provider, so tests run

* fix implicit code syntax
* avoid excessive todo churn

* Update infra/modules/worklytics-connectors-msft-365/main.tf

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
* improve tooling to warn user if repo checkout dir does not exist

* warn user if didn't pass in version

* provide suggestion to do terraform init --upgrade

* to ease publishing, bring example repos READMEs into main one

* monorepo instructions

* Update tools/upgrade-terraform-modules.sh

Co-authored-by: Copilot <[email protected]>

* Update infra/examples-dev/aws/README_to_publish.md

Co-authored-by: Jose Lorenzo <[email protected]>

* Update infra/examples-dev/aws/README_to_publish.md

Co-authored-by: Jose Lorenzo <[email protected]>

* Update infra/examples-dev/aws/README_to_publish.md

Co-authored-by: Jose Lorenzo <[email protected]>

* Update infra/examples-dev/aws/README_to_publish.md

Co-authored-by: Jose Lorenzo <[email protected]>

* Update infra/examples-dev/gcp/README_to_publish.md

Co-authored-by: Jose Lorenzo <[email protected]>

* fix version refs in example readme

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Jose Lorenzo <[email protected]>
* Updated example with rateLimit

* Updated rules

* Updated YAML

* Updated CHANGELOG.md
* bucket write role conditional on bulk_mode being enabled

* remove unused deprescated values; inputs/outputs that shouldn't be relevant

* revert conditional custom_role thing; not helpful in practice

* commit the depends_on

* avoid failing test
* approach to given better token decryption errors

* .gitignore to avoid copilot config files atm

* Better name, add TODO

* fix compile

* better split up error cases

* fix type

* fix weird import/ref
* configurable timeout for gcp bulk case

* fix style

* Update infra/modules/gcp-host/main.tf

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
* script to replay gcs writes on a bucket

* move the tool

* perms feedback

* fix leading whitespacE

* single object case

* be flexible on uri format

* Update tools/gcp/replay-gcs-writes.sh

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
* avoid non-determinism, although this breaks if NOT auth'd as a service account

* wip of DROPPING data.external, which is hack; and data.google_service_account_id_token, which fails in some cases - but can't be easily conditioned pre-apply

* add some comments

* refactor to flatten/simplify module structure

* drop module that's been deprecated since 0.4.19, at least

* todo, recover the test

* recover conditional service_account thing, trying to avoid breaking changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Atlassian documentation for Jira and Confluence to remove unnecessary permissions and simplify installation by not requiring manual ACCESS_TOKEN pasting. The changes focus on documentation cleanup and tooling improvements.

  • Removed read:account permission requirement from Jira and Confluence OAuth configurations
  • Updated authentication scripts to eliminate the need for manual ACCESS_TOKEN entry
  • Enhanced documentation with direct links to relevant API endpoints for each permission

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/jira-cloud-auth.sh Removed read:account scope from authorization URL and eliminated ACCESS_TOKEN output instruction
tools/confluence-cloud-auth.sh Removed ACCESS_TOKEN output instruction from the script
infra/modules/worklytics-connector-specs/main.tf Updated documentation to remove read:account permission and added API endpoint links
docs/sources/atlassian/jira/README.md Removed read:account permission and added helpful API endpoint links
docs/sources/atlassian/confluence/README.md Removed read:account permission requirement from setup instructions
CHANGELOG.md Added entry documenting the removal of read:accounts permission

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eschultink eschultink deleted the branch rc-v0.5.10 October 2, 2025 16:04
@eschultink eschultink closed this Oct 2, 2025
@eschultink eschultink reopened this Oct 2, 2025
cursor[bot]

This comment was marked as outdated.

@eschultink eschultink enabled auto-merge (squash) October 2, 2025 16:25
@eschultink eschultink merged commit 1cdb833 into rc-v0.5.10 Oct 2, 2025
47 checks passed
@eschultink eschultink deleted the atlassian_docs branch October 2, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants