-
Notifications
You must be signed in to change notification settings - Fork 6
Update Atlassian docs #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Atlassian docs #1010
Conversation
* Updated rules * Updated rule for isMove * Updated test result
* add some clarity to header handling * improve naming of it on endpoint * fix rename
* expose configurable google workspace key rotation; implement it in a better way * Update infra/examples-dev/gcp/google-workspace-variables.tf Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* document some additional bulk file settings * some fixes for jira/confluence docs * fix passing through columnsToPseudonymizeIfPresent; add tests to cover that; generalize module testing infra * test the gcp-host module * doc zoom Server-to-Server OAuth app creation perm in roles * line-wrapping in zoom docs * doc requirement for Cloudscheduler admin; and note that it's only least-privileged extant role; a less-privileged custom role is possible * fix test file per bugbot suggestion * document 'applyOnlyWhen' * try to fix test for tf 1.6.x * add CI coverage of more recent tf versions * typo in salesfroce docs * recover gcp-host CI mock provider, so tests run * fix implicit code syntax
* avoid excessive todo churn * Update infra/modules/worklytics-connectors-msft-365/main.tf Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* improve tooling to warn user if repo checkout dir does not exist * warn user if didn't pass in version * provide suggestion to do terraform init --upgrade * to ease publishing, bring example repos READMEs into main one * monorepo instructions * Update tools/upgrade-terraform-modules.sh Co-authored-by: Copilot <[email protected]> * Update infra/examples-dev/aws/README_to_publish.md Co-authored-by: Jose Lorenzo <[email protected]> * Update infra/examples-dev/aws/README_to_publish.md Co-authored-by: Jose Lorenzo <[email protected]> * Update infra/examples-dev/aws/README_to_publish.md Co-authored-by: Jose Lorenzo <[email protected]> * Update infra/examples-dev/aws/README_to_publish.md Co-authored-by: Jose Lorenzo <[email protected]> * Update infra/examples-dev/gcp/README_to_publish.md Co-authored-by: Jose Lorenzo <[email protected]> * fix version refs in example readme --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Jose Lorenzo <[email protected]>
* Updated example with rateLimit * Updated rules * Updated YAML * Updated CHANGELOG.md
* bucket write role conditional on bulk_mode being enabled * remove unused deprescated values; inputs/outputs that shouldn't be relevant * revert conditional custom_role thing; not helpful in practice * commit the depends_on * avoid failing test
* approach to given better token decryption errors * .gitignore to avoid copilot config files atm * Better name, add TODO * fix compile * better split up error cases * fix type * fix weird import/ref
* configurable timeout for gcp bulk case * fix style * Update infra/modules/gcp-host/main.tf Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* script to replay gcs writes on a bucket * move the tool * perms feedback * fix leading whitespacE * single object case * be flexible on uri format * Update tools/gcp/replay-gcs-writes.sh Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* avoid non-determinism, although this breaks if NOT auth'd as a service account * wip of DROPPING data.external, which is hack; and data.google_service_account_id_token, which fails in some cases - but can't be easily conditioned pre-apply * add some comments * refactor to flatten/simplify module structure * drop module that's been deprecated since 0.4.19, at least * todo, recover the test * recover conditional service_account thing, trying to avoid breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Atlassian documentation for Jira and Confluence to remove unnecessary permissions and simplify installation by not requiring manual ACCESS_TOKEN pasting. The changes focus on documentation cleanup and tooling improvements.
- Removed
read:accountpermission requirement from Jira and Confluence OAuth configurations - Updated authentication scripts to eliminate the need for manual ACCESS_TOKEN entry
- Enhanced documentation with direct links to relevant API endpoints for each permission
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/jira-cloud-auth.sh | Removed read:account scope from authorization URL and eliminated ACCESS_TOKEN output instruction |
| tools/confluence-cloud-auth.sh | Removed ACCESS_TOKEN output instruction from the script |
| infra/modules/worklytics-connector-specs/main.tf | Updated documentation to remove read:account permission and added API endpoint links |
| docs/sources/atlassian/jira/README.md | Removed read:account permission and added helpful API endpoint links |
| docs/sources/atlassian/confluence/README.md | Removed read:account permission requirement from setup instructions |
| CHANGELOG.md | Added entry documenting the removal of read:accounts permission |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ACCESS_TOKENduring installation.read:accountsfrom permissions, as it is not usedUpdate docs for Confluence, Jira. Update tooling.
Features
confusing docs in jira scopes
in Jira/confluence case, does customer actually NEED to fill access_tokn
Change implications
CHANGELOG.mdanything that will show up interraform plan/applythat isn'tobviously a no-op? yes, for documenting purposes only
alpha, requires major versionchange no