ota: default to enabled #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lus.services.x1plusd.settings, because clients are responsible for choosing their own defaults
Member
Author
|
Wow, two fixes for the price of one! Tested on my printer. |
jphannifan
approved these changes
Jun 11, 2024
ima-hima
pushed a commit
to ima-hima/X1PlusPolarCloud
that referenced
this pull request
Jun 19, 2024
* x1plusd: there actually do not need to be any default settings in x1plus.services.x1plusd.settings, because clients are responsible for choosing their own defaults * ota: default to enabled * kexec_ui: correctly interpolate strings in BootOptionsPage cleanup mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, originally we thought that the OTA engine should default to disabled. This is clearly wrong. It should default to enabled. While we're in there, remove the other confusing defaults that are not useful and just add clutter and confusion.
Also fixes 'Reset X1Plus Settings' to actually do what it says on the tin.