Migrate HardwarePage.qml settings #378
Conversation
New X1Plus settings keys: 1. lcd.brightness (float) backlight brightness 2. leds.toolhead (bool) toolhead LED on or off Removed the display brightness timer because we don't need it. The slider's value is saved using an onPressedChanged signal Also a random thought, but the toolhead LED setting would probably be more useful if it asked users if they want to override the OEM LED state, and if they enable this, then they can choose to have it always on or always off. The way it works right now is .. odd
| if (!pressed) { | ||
| X1Plus.Settings.put("lcd.brightness", brightness); | ||
| } |
There was a problem hiding this comment.
this is a dramatically better way to do this, nice find!
| dynamicChecked: DeviceManager.getSetting("cfw_toolhead_led", false) | ||
| dynamicChecked: X1Plus.Settings.get("leds.toolhead",false) | ||
| onToggled: { | ||
| dynamicChecked = checked |
There was a problem hiding this comment.
I think this line can die. then, if it does, magically x1plus settings put leds.toolhead will update in the UI. hmm, but it still wouldn't result in a toggled event...
anyway either way this would not be a regression so definitely +1 from me
jwise
left a comment
There was a problem hiding this comment.
this looks good to me, I have not tried it on my printer but I am solidly on board with killifying these remaining two cfw_ props in the GUI
bani6809
left a comment
There was a problem hiding this comment.
does not work. backlight does not save settings. boots up with min brightness always, despite slider showing max brightness
ty for spotting this. I will have a fix ready to test soon |
The LCD brightness and toolhead LED settings are still set by Devicemanager. This migrates those settings.
New keys:
leds.toolheadlcd.brightness