Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@LaurentMag
Copy link
Contributor

@LaurentMag LaurentMag commented Feb 15, 2024

Description

What are changes related to ?

change time since declaration update, fix translation to correctly use plural for hours and minutes

Linked Issues

What are the issues fixed by this pull request ?
#1245 #1309

Changes

What does it change ?
Is is a breaking change ?
Is is a new feature ?
Is is a patch, fix, hotfix ?

Screenshots

Put screenshots (if any)

Tests

How has it been tested ?

  • Manually
  • Automated tests
  • QA
  • Other

Additional information

Precise any other information

@github-actions
Copy link

Label bug 🐛 has been added to this pull request

@github-actions github-actions bot added the bug 🐛 Something isn't working label Feb 15, 2024
@LaurentMag LaurentMag force-pushed the fix/mobile_declaration_time_text_plural branch from d8d2ff8 to d127808 Compare February 15, 2024 13:58
@github-actions
Copy link

Label bug 🐛 has been added to this pull request

…slation taking into account plural for minutes and hours
@LaurentMag LaurentMag force-pushed the fix/mobile_declaration_time_text_plural branch from d127808 to 6d02765 Compare February 15, 2024 14:16
@github-actions
Copy link

Label bug 🐛 has been added to this pull request

Copy link
Contributor

@NyraSama NyraSama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurentMag LaurentMag merged commit 3d61914 into main Feb 15, 2024
@LaurentMag LaurentMag deleted the fix/mobile_declaration_time_text_plural branch February 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants