Feat add jumpers and variables #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a53fb63 to
7862741
Compare
7862741 to
140fcbe
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the faithful reviewer of this PR, first of all, thanks for the time you are allowing me!
Initially, the commits list on which I’ve worked was completely barbaric. So I rebase and simplified it to let this review be more accessible.
Below you’ll find, commit after commit, a list of the things I’ve added or “fixed” in the code:
This commit contains the
Variablestruct and it’s enums unmarshallingThis commit contains the
Jumpersstruct and it’s loading mechanism (validation, json schemas, …)This commit do the glue between the previous commit and the menus of the application (heavily inspired by plugins and hotKeys)
This commit setup the skeleton of “how variables are computed” without using the dialogs correlated to the
sourceThis commit add 2 new dialogs and use them on the variable computation from last commit
This commit implement view navigation
This commit allow the
backgroundoption ofshellOptsto be used when pipingThis commit fix an issue that I add when using quotes on the pipe command, that misinterpret the pipe command.
google/shlexwas an indirect dependency, that’s why I allow myself to use it, but it’s not maintained anymore: https://github.com/google/shlexThis commit add printed data to
k9s infocommandThis commit fix label parsing, by keeping case of input
See original Issue to understand why
This commit brings variables to the plugins too
The commit marked with⚠️ need a very careful attention, because their impact can be more important than I was able to conceive.