Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cindyyan317
Copy link
Contributor

When there was an ETL not working and allow_no_etl is false, Clio would fail to start.
This PR improved the behavior. As long as there is one ETL working, Clio should be able to start.

@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.78%. Comparing base (37cd79c) to head (7483320).

Current head 7483320 differs from pull request most recent head fd0a31d

Please upload reports for the commit fd0a31d to get more accurate results.

Files Patch % Lines
src/etl/LoadBalancer.cpp 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1465      +/-   ##
===========================================
- Coverage    67.81%   67.78%   -0.03%     
===========================================
  Files          233      233              
  Lines         9416     9418       +2     
  Branches      5251     5253       +2     
===========================================
- Hits          6385     6384       -1     
- Misses        1653     1654       +1     
- Partials      1378     1380       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cindyyan317 cindyyan317 merged commit 5ba08b1 into XRPLF:develop Jun 17, 2024
kuznetsss pushed a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants