test: add tests for fee voting #5747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/se/fees #5747 +/- ##
================================================
- Coverage 79.3% 79.3% -0.0%
================================================
Files 825 825
Lines 74283 74283
Branches 8504 8507 +3
================================================
- Hits 58923 58918 -5
- Misses 15360 15365 +5 see 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
oleks-rip
reviewed
Sep 12, 2025
oleks-rip
reviewed
Sep 12, 2025
oleks-rip
reviewed
Sep 12, 2025
oleks-rip
reviewed
Sep 12, 2025
oleks-rip
reviewed
Sep 12, 2025
oleks-rip
reviewed
Sep 12, 2025
c227bdc to
a99cb4b
Compare
oleks-rip
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds more comprehensive tests for fee voting, specifically the Smart Escrow parts.
Context of Change
An important part of the flow that has yet to be tested
Downstream of #5746
Type of Change
API Impact
N/A
Test Plan
This PR is only tests, and it passes in CI.