Fix gsim resolve -v flag failed to propagate arguments to gsim #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the -v flag failed to propagate arguments to gsim and includes performance improvements to FIRRTL file parsing.
- Fixed argument parsing logic in the CMake build system to properly handle gsim flags separated by semicolons
- Optimized FIRRTL file parsing by replacing regex-based parsing with string operations for better performance
- Added debug logging to track port parsing progress
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| template/lib/cmake/gsim.cmake | Fixed flag propagation by converting semicolon-separated flags to space-separated arguments |
| src/parser/firrtl.cpp | Replaced regex parsing with string operations and added debug logging for performance optimization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6b536ef to
8b750bf
Compare
Makiras
previously approved these changes
Sep 5, 2025
FrankOu2001
reviewed
Sep 5, 2025
FrankOu2001
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces performance improvements to the FIRRTL file parsing logic in firrtl.cpp and resolves a bug where the -v flag failed to propagate arguments to gsim.
Type of change
How Has This Been Tested?
run picker command like this
picker export SimTop.fir --sim gsim -V "--supernode-max-size=2;--cpp-max-size-KB=8192"Checklist: