Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Await overload with IExecutor (#193) #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2023
Merged

Added Await overload with IExecutor (#193) #234

merged 3 commits into from
Feb 16, 2023

Conversation

@harashimahashi
Copy link
Contributor

@harashimahashi harashimahashi commented Feb 12, 2023 •
edited
Loading

Purpose

#193

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@codecov
Copy link

codecov bot commented Feb 12, 2023 •
edited
Loading

Codecov Report

Merging #234 (96a49c5) into main (9ece55a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        68    +2     
  Lines         1543      1583   +40     
=========================================
+ Hits          1543      1583   +40
Impacted Files Coverage Δ
include/yaclib/coro/detail/await_on_awaiter.hpp 100.00% <100.00%> (ø)
include/yaclib/coro/await_on.hpp 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt self-assigned this Feb 13, 2023
@harashimahashi harashimahashi force-pushed the 193-add-await-overload-with-iexecutor branch 3 times, most recently from 8e64a72 to 276b2e7 Compare February 14, 2023 23:06
MBkkt
MBkkt reviewed Feb 14, 2023
View reviewed changes
@harashimahashi harashimahashi force-pushed the 193-add-await-overload-with-iexecutor branch from 276b2e7 to 9bdedae Compare February 14, 2023 23:54
@harashimahashi harashimahashi assigned MBkkt and unassigned MBkkt Feb 14, 2023
MBkkt
MBkkt reviewed Feb 15, 2023
View reviewed changes
@harashimahashi harashimahashi force-pushed the 193-add-await-overload-with-iexecutor branch from 9bdedae to cc8b7af Compare February 15, 2023 15:33
@harashimahashi harashimahashi assigned MBkkt and unassigned MBkkt Feb 15, 2023
@harashimahashi harashimahashi force-pushed the 193-add-await-overload-with-iexecutor branch from cc8b7af to faae5ab Compare February 15, 2023 17:31
@harashimahashi harashimahashi assigned MBkkt and unassigned MBkkt Feb 15, 2023
@harashimahashi harashimahashi force-pushed the 193-add-await-overload-with-iexecutor branch from faae5ab to 96a49c5 Compare February 15, 2023 20:03
@harashimahashi harashimahashi assigned MBkkt and unassigned MBkkt Feb 15, 2023
@MBkkt MBkkt merged commit 285b145 into main Feb 16, 2023
@MBkkt MBkkt deleted the 193-add-await-overload-with-iexecutor branch December 7, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MBkkt MBkkt MBkkt approved these changes

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@MBkkt MBkkt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harashimahashi @MBkkt