Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bring SharedFuture feature set on par with regular Future #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 3, 2025
Merged

Bring SharedFuture feature set on par with regular Future #267

merged 7 commits into from
Sep 3, 2025

Conversation

@ocelaiwo
Copy link
Contributor

Purpose

This PR adds the following features to SharedFuture:

  • Add SharedFutureOn similar to FutureOn
  • Make SharedFuture/On API more similar to that of Future/On
  • Add RunShared
  • Add AsyncSharedContract
  • Allow SharedFuture to be the return type of a coroutine
  • Allow to Await on SharedFuture in the coroutine context

@coveralls
Copy link

coveralls commented Aug 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17387487227

Details

  • 166 of 166 (100.0%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 17010738286: 0.0%
Covered Lines: 2027
Relevant Lines: 2027
💛 - Coveralls

@ocelaiwo ocelaiwo force-pushed the shared_future_features branch from 9518211 to 3565b38 Compare August 25, 2025 12:51
MBkkt
MBkkt reviewed Aug 25, 2025
View reviewed changes
@ocelaiwo ocelaiwo force-pushed the shared_future_features branch 2 times, most recently from 4289a5e to 0fba84e Compare August 27, 2025 10:30
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 95.78947% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.41%. Comparing base (f8dfca4) to head (0fba84e).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
include/yaclib/algo/detail/shared_event.hpp 83.33% 2 Missing ⚠️
include/yaclib/async/shared_future.hpp 93.54% 2 Missing ⚠️
include/yaclib/coro/detail/promise_type.hpp 84.61% 2 Missing ⚠️
include/yaclib/util/result.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##              main     #267      +/-   ##
===========================================
- Coverage   100.00%   99.41%   -0.59%     
===========================================
  Files           75       81       +6     
  Lines         1828     2054     +226     
===========================================
+ Hits          1828     2042     +214     
- Misses           0       12      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ocelaiwo ocelaiwo force-pushed the shared_future_features branch from 0fba84e to 1d8e1ca Compare August 27, 2025 12:40
@ocelaiwo ocelaiwo force-pushed the shared_future_features branch from 1d8e1ca to 1fb3015 Compare August 27, 2025 12:56
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 27, 2025
View reviewed changes
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetBaseHandle => GetHandle

@ocelaiwo ocelaiwo force-pushed the shared_future_features branch 3 times, most recently from ee684d1 to e7de9d4 Compare August 28, 2025 20:27
@ocelaiwo ocelaiwo force-pushed the shared_future_features branch from e7de9d4 to f2e3415 Compare August 28, 2025 20:57
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
MBkkt
MBkkt reviewed Aug 29, 2025
View reviewed changes
@ocelaiwo ocelaiwo force-pushed the shared_future_features branch from 8724938 to 2016d44 Compare September 1, 2025 17:46
@MBkkt MBkkt marked this pull request as ready for review September 1, 2025 18:16
@MBkkt MBkkt requested a review from kononovk as a code owner September 1, 2025 18:16
MBkkt
MBkkt reviewed Sep 1, 2025
View reviewed changes
@ocelaiwo ocelaiwo force-pushed the shared_future_features branch from 0b0a50b to e71c3d2 Compare September 1, 2025 20:24
@MBkkt MBkkt self-assigned this Sep 1, 2025
@ocelaiwo ocelaiwo assigned ocelaiwo and unassigned MBkkt Sep 1, 2025
@MBkkt MBkkt merged commit 35a388a into YACLib:main Sep 3, 2025
56 checks passed
@ocelaiwo ocelaiwo deleted the shared_future_features branch September 3, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MBkkt MBkkt MBkkt approved these changes

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@ocelaiwo ocelaiwo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ocelaiwo @coveralls @MBkkt