Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Yizack
Copy link
Owner

@Yizack Yizack commented Oct 23, 2025

Consolidates all module exports into the main entry point by removing the separate mailchannels-sdk/modules export. Updates documentation to use named imports from mailchannels-sdk instead of subpath imports.

Consolidates all module exports into the main entry point by removing the separate './modules' export from package.json and build config. Updates documentation to use named imports from 'mailchannels-sdk' instead of subpath imports. Also removes redundant type re-exports from src/modules.ts and ensures all modules are exported from src/mailchannels.ts.
@Yizack Yizack self-assigned this Oct 23, 2025
@Yizack Yizack requested a review from Copilot October 23, 2025 10:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates module exports by enforcing a single import pattern, requiring all exports to come from the main 'mailchannels-sdk' entry point instead of allowing subpath imports like 'mailchannels-sdk/modules'.

Key Changes:

  • Removed the './modules' export path from package.json and build configuration
  • Updated all documentation examples to use named imports directly from 'mailchannels-sdk'
  • Re-exported all modules through the main entry point (src/mailchannels.ts)

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/modules.ts Removed redundant type re-exports that are now handled by the main entry point
src/mailchannels.ts Added wildcard export to expose all modules from the main entry point
package.json Removed the './modules' subpath export configuration
build.config.ts Removed './src/modules' from build entries to build only the main entry point
docs/modules/*.md Updated all code examples to import modules directly from 'mailchannels-sdk' instead of 'mailchannels-sdk/modules'
docs/guide.md Updated example to use single-line import from 'mailchannels-sdk'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bf980db) to head (f5b0d62).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          810       810           
  Branches       146       146           
=========================================
  Hits           810       810           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yizack Yizack merged commit 3957998 into main Oct 23, 2025
8 checks passed
@Yizack Yizack deleted the refactor/single-import-pattern branch October 23, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants