Fix for SDL_WINDOWEVENT_RESTORED not being generated on MacOS #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mac, the SDL_cocoawindow observeValueForKeyPath callback generates a SDL_WINDOWEVENT_SHOWN event before the SDL_WINDOWEVENT_RESTORED gets generated. SDL_WINDOWEVENT_SHOWN unsets the SDL_WINDOW_MINIMIZED flag; this in turn causes SDL_WINDOWEVENT_RESTORED event to return before being posted, as the window is neither minimized or maximized. I also considered calling SDL_SendWindowEvent() from observeValueForKeyPath in SDL_cocoawindow just before we call SendWindowEvent for SDL_WINDOWEVENT_SHOWN - this also fixes the bug, but results in SDL_WINDOWEVENT_RESTORED being generated twice, with the second time returning early due to the window no longer being minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On mac, the SDL_cocoawindow observeValueForKeyPath callback generates a SDL_WINDOWEVENT_SHOWN event before the SDL_WINDOWEVENT_RESTORED gets generated. SDL_WINDOWEVENT_SHOWN unsets the SDL_WINDOW_MINIMIZED flag; this in turn causes SDL_WINDOWEVENT_RESTORED event to return before being posted, as the window is neither minimized or maximized.
I also considered calling SDL_SendWindowEvent() from observeValueForKeyPath in SDL_cocoawindow just before we call SendWindowEvent for SDL_WINDOWEVENT_SHOWN - this also fixes the bug, but results in SDL_WINDOWEVENT_RESTORED being generated twice, with the second time returning early due to the window no longer being minimized.