Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Oct 3, 2025

Context

  • We don't want to run the register_hooks and get_conditionals when a class is deprecated.

Summary

This PR can be summarized in the following changelog entry:

  • Makes sure deprecated classes are not called when they are not supposed to.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Clear your debug.log and click through your site and make sure nothing about deprecated classes show up.
  • Make sure you have this enabled:
if ( ! defined( 'WP_DEBUG' ) ) {
	define( 'WP_DEBUG', true );
}
if ( ! defined( 'WP_DEBUG_LOG' ) ) {
	define( 'WP_DEBUG_LOG', true );
}

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 3, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7fc7df28b926061d4a39b515d4c7cee60924af86

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.7%) to 52.824%

Totals Coverage Status
Change from base Build 73b94de18dd2ab17cf50de2a305813e4d59c1f63: -3.7%
Covered Lines: 31335
Relevant Lines: 59482

💛 - Coveralls

Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 modified the milestones: 26.2, 26.3 Oct 13, 2025
@pls78 pls78 merged commit 99c83c5 into trunk Oct 13, 2025
29 of 30 checks passed
@pls78 pls78 deleted the try/solve-deprecation-in-logs branch October 13, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants