`icemulti' error checks and argument handling #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. @zeldin You wrote the original |
zeldin
approved these changes
Sep 5, 2017
zeldin
approved these changes
Sep 5, 2017
|
Looks ok. getopt_long is not standard, but I guess it's common enough. The one thing I'm a bit curious about is why the check if the number of images is zero was removed. Is there a point to creating a multi-image with zero images in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pull request #92 doesn't appear to make any progress, I'm creating a pull request for the next part of the
icemultichanges without a test suite. This pull request introduces thegetoptlibrary for parsing command-line arguments, adds some missing error checks (for missing or empty input files and I/O errors) and provides more information with the existing error checks (program and file name).